Messages in this thread | | | Date | Fri, 20 Oct 2023 15:16:16 -0400 | From | Willem de Bruijn <> | Subject | Re: [PATCH v3 net-next 2/3] ipv6: refactor ip6_finish_output for GSO handling |
| |
Yan Zhai wrote: > Separate GSO and non-GSO packets handling to make the logic cleaner. For > GSO packets, frag_max_size check can be omitted because it is only > useful for packets defragmented by netfilter hooks. Both local output > and GRO logic won't produce GSO packets when defragment is needed. This > also mirrors what IPv4 side code is doing. > > Suggested-by: Florian Westphal <fw@strlen.de> > Signed-off-by: Yan Zhai <yan@cloudflare.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Thanks for splitting up the series. This change alone is subtle enough that it benefits from standing alone. I thought it was intended to be a NOOP, but you indeed call out the frag_max_size special case.
| |