lkml.org 
[lkml]   [2023]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/5] avoid divide-by-zero due to max_nr_accesses overflow
Date
On Fri, 20 Oct 2023 17:19:01 +0000 SeongJae Park <sj@kernel.org> wrote:

> On Thu, 19 Oct 2023 19:49:19 +0000 SeongJae Park <sj@kernel.org> wrote:
>
> > The maximum nr_accesses of given DAMON context can be calculated by
> > dividing the aggregation interval by the sampling interval. Some logics
> > in DAMON uses the maximum nr_accesses as a divisor. Hence, the value
> > shouldn't be zero. Such case is avoided since DAMON avoids setting the
> > agregation interval as samller than the sampling interval. However,
> > since nr_accesses is unsigned int while the intervals are unsigned long,
> > the maximum nr_accesses could be zero while casting.
>
> Actually, the issue was reported by Jakub, and I didn't add 'Reported-by:' tags
> for him. I sure Andrew could add that on his own, but I want to minimize
> Andrew's load, so will send v2 of this patchset. Andrew, please let me know if
> that doesn't help but only increasing your load.

So sent the second version[1] with the
"Reported-by: akub Acs <acsjakub@amazon.de>" line, but then I noticed the patch
is already added to mm queue[2]. Somehow the notification mails delivered bit
later than usual.

Sorry for making this noise, Andrew. Please add
"Reported-by: akub Acs <acsjakub@amazon.de>" to already added patches, or
replace those with the v2 if possible. Also, please let me know if there's
anything I could help.

[1] https://lore.kernel.org/damon/20231020172317.64192-1-sj@kernel.org/
[2] https://lore.kernel.org/mm-commits/20231020171847.C6EEAC433C7@smtp.kernel.org/


Thanks,
SJ

>
>
> Thanks,
> SJ
>

\
 
 \ /
  Last update: 2023-10-20 19:31    [W:0.438 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site