Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Fri, 20 Oct 2023 19:05:37 +0200 | Subject | Re: [PATCH v1 5/8] ACPI: x86: use acpi_dev_uid_match() for matching _UID |
| |
On Fri, Oct 20, 2023 at 12:38 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Fri, Oct 20, 2023 at 02:17:29PM +0530, Raag Jadav wrote: > > Convert manual _UID references to use standard ACPI helpers. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > ... > > > - if (!adev->pnp.unique_id || > > - strcmp(adev->pnp.unique_id, override_status_ids[i].uid)) > > + if (!acpi_dev_uid_match(adev, override_status_ids[i].uid)) > > The check for NULL argument inside that API does not affect the behaviour as > otherwise it will be a crash with the current implementation.
What current implementation do you mean, exactly?
| |