Messages in this thread | | | Date | Fri, 20 Oct 2023 09:53:48 -0600 | Subject | Re: [PATCH net-next 3/5] ipv6: add new arguments to udp_tunnel6_dst_lookup() | From | David Ahern <> |
| |
On 10/20/23 5:55 AM, Beniamino Galvani wrote: > We want to make the function more generic so that it can be used by > other UDP tunnel implementations such as geneve and vxlan. To do that, > add the following arguments: > > - source and destination UDP port; > - ifindex of the output interface, needed by vxlan; > - the tos, because in some cases it is not taken from struct > ip_tunnel_info (for example, when it's inherited from the inner > packet); > - the dst cache, because not all tunnel types (e.g. vxlan) want to > use the one from struct ip_tunnel_info. > > With these parameters, the function no longer needs the full struct > ip_tunnel_info as argument and we can pass only the relevant part of > it (struct ip_tunnel_key). > > This is similar to what already done for IPv4 in commit 72fc68c6356b > ("ipv4: add new arguments to udp_tunnel_dst_lookup()"). > > Suggested-by: Guillaume Nault <gnault@redhat.com> > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com> > --- > drivers/net/bareudp.c | 10 +++++++--- > include/net/udp_tunnel.h | 7 ++++--- > net/ipv6/ip6_udp_tunnel.c | 33 ++++++++++++++++++--------------- > 3 files changed, 29 insertions(+), 21 deletions(-) >
Reviewed-by: David Ahern <dsahern@kernel.org>
| |