Messages in this thread | | | Date | Fri, 20 Oct 2023 14:38:06 +0300 | From | Raag Jadav <> | Subject | Re: [PATCH v1 4/8] ACPI: utils: use acpi_dev_uid_match() for matching _UID |
| |
On Fri, Oct 20, 2023 at 01:36:27PM +0300, Andy Shevchenko wrote: > On Fri, Oct 20, 2023 at 02:17:28PM +0530, Raag Jadav wrote: > > Convert manual _UID references to use standard ACPI helpers. > > Yes, while not so obvious this is the correct replacement. > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
I think this is the only case which would suffer from the more obvious behaviour, i.e.
bool acpi_dev_uid_match(struct acpi_device *adev, const char *uid2) { const char *uid1 = acpi_device_uid(adev);
return uid1 && uid2 && !strcmp(uid1, uid2); }
That said, we can't be particularly sure about it's potential future users, especially when the usage will not be limited to just ACPI core since we're exporting it.
Raag
| |