Messages in this thread | | | From | "Pucha, HimasekharX Reddy" <> | Subject | RE: [Intel-wired-lan] [PATCH net v2] i40e: Fix I40E_FLAG_VF_VLAN_PRUNING value | Date | Fri, 20 Oct 2023 05:44:11 +0000 |
| |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Ivan Vecera > Sent: Thursday, October 19, 2023 10:07 PM > To: netdev@vger.kernel.org > Cc: Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>; Palczewski, Mateusz <mateusz.palczewski@intel.com>; Brandeburg, Jesse <jesse.brandeburg@intel.com>; open list <linux-kernel@vger.kernel.org>; Eric Dumazet <edumazet@google.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Simon Horman <horms@kernel.org>; Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller <davem@davemloft.net>; moderated list:INTEL ETHERNET DRIVERS <intel-wired-lan@lists.osuosl.org> > Subject: [Intel-wired-lan] [PATCH net v2] i40e: Fix I40E_FLAG_VF_VLAN_PRUNING value > > Commit c87c938f62d8f1 ("i40e: Add VF VLAN pruning") added new > PF flag I40E_FLAG_VF_VLAN_PRUNING but its value collides with > existing I40E_FLAG_TOTAL_PORT_SHUTDOWN_ENABLED flag. > > Move the affected flag at the end of the flags and fix its value. > > Reproducer: > [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 link-down-on-close on > [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 vf-vlan-pruning on > [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 link-down-on-close off > [ 6323.142585] i40e 0000:02:00.0: Setting link-down-on-close not supported on this port (because total-port-shutdown is enabled) > netlink error: Operation not supported > [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 vf-vlan-pruning off > [root@cnb-03 ~]# ethtool --set-priv-flags enp2s0f0np0 link-down-on-close off > > The link-down-on-close flag cannot be modified after setting vf-vlan-pruning > because vf-vlan-pruning shares the same bit with total-port-shutdown flag > that prevents any modification of link-down-on-close flag. > > Fixes: c87c938f62d8 ("i40e: Add VF VLAN pruning") > Cc: Mateusz Palczewski <mateusz.palczewski@intel.com> > Cc: Simon Horman <horms@kernel.org> > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > --- > drivers/net/ethernet/intel/i40e/i40e.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
| |