Messages in this thread | | | Date | Mon, 2 Oct 2023 10:38:11 -0700 | From | Kees Cook <> | Subject | Re: [PATCH][next] udf: Fix undefined behavior bug in struct udf_fileident_iter |
| |
On Mon, Oct 02, 2023 at 06:14:26PM +0200, Gustavo A. R. Silva wrote: > `struct fileIdentDesc` is a flexible structure, which means that it > contains a flexible-array member at the bottom. This could potentially > lead to an overwrite of the objects following `fi` in `struct > udf_fileident_iter` at run-time. > > Fix this by placing the declaration of object `fi` at the end of > `struct udf_fileident_iter`. > > -Wflex-array-member-not-at-end is coming in GCC-14, and we are getting > ready to enable it globally. > > Fixes: d16076d9b684 ("udf: New directory iteration code") > Cc: stable@vger.kernel.org > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Looks right.
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |