Messages in this thread | | | Date | Mon, 2 Oct 2023 14:09:53 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH v1] mtd: spinand: add support for FORESEE F35SQA002G |
| |
Hi Martin,
mmkurbanov@salutedevices.com wrote on Mon, 2 Oct 2023 13:18:18 +0300:
> Hi Miquel, > Thanks for your review. > > On 02.10.2023 12:44, Miquel Raynal wrote: > > Hi Martin, > >> +static int f35sqa002g_ooblayout_free(struct mtd_info *mtd, int section, > >> + struct mtd_oob_region *region) > >> +{ > >> + /* XXX: It is not possible to partially write to this OOB area, as both > >> + * the main and OOB areas are protected by ECC. The user needs to > >> + * program both the main area and OOB area at one programming time, > >> + * so that the ECC parity code can be calculated properly. > >> + */ > > > > Is this comment really needed? I believe it could be dropped, unless > > you are really experiencing strange subpage write attempts? > > If you write separately to the main area and the OOB area. This is the > case with many SPI NAND chips, I agree that this comment can be dropped. >
All NAND chips have this limitation actually. I guess you can just get rid of the comment. The rest looks ok.
Thanks, Miquèl
| |