lkml.org 
[lkml]   [2023]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v9 07/53] media: sti: hva: Use vb2_get_buffer() instead of directly access to buffers array
    Date
    Use vb2_get_buffer() instead of directly access to vb2_buffer buffer array.
    After each call to vb2_get_buffer() we need to be sure that we get
    a valid pointer so check the return value of all of them.
    Remove index range test since it is done by vb2_get_buffer().

    Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
    ---
    drivers/media/platform/st/sti/hva/hva-v4l2.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/media/platform/st/sti/hva/hva-v4l2.c b/drivers/media/platform/st/sti/hva/hva-v4l2.c
    index 3a848ca32a0e..cfe83e9dc01b 100644
    --- a/drivers/media/platform/st/sti/hva/hva-v4l2.c
    +++ b/drivers/media/platform/st/sti/hva/hva-v4l2.c
    @@ -569,14 +569,11 @@ static int hva_qbuf(struct file *file, void *priv, struct v4l2_buffer *buf)
    struct vb2_buffer *vb2_buf;

    vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, buf->type);
    -
    - if (buf->index >= vq->num_buffers) {
    - dev_dbg(dev, "%s buffer index %d out of range (%d)\n",
    - ctx->name, buf->index, vq->num_buffers);
    + vb2_buf = vb2_get_buffer(vq, buf->index);
    + if (!vb2_buf) {
    + dev_dbg(dev, "%s buffer index %d not found\n", ctx->name, buf->index);
    return -EINVAL;
    }
    -
    - vb2_buf = vb2_get_buffer(vq, buf->index);
    stream = to_hva_stream(to_vb2_v4l2_buffer(vb2_buf));
    stream->bytesused = buf->bytesused;
    }
    --
    2.39.2
    \
     
     \ /
      Last update: 2023-10-02 14:08    [W:5.384 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site