Messages in this thread | | | Date | Wed, 18 Oct 2023 16:48:00 +0100 | From | Catalin Marinas <> | Subject | Re: [PATCH v3 5/7] mm: kmemleak: use mem_pool_free() to free object |
| |
On Wed, Oct 18, 2023 at 06:29:50PM +0800, Liu Shixin wrote: > The kmemleak object is allocated by mem_pool_alloc(), which > could be from slab or mem_pool[], so it's not suitable using > __kmem_cache_free() to free the object, use __mem_pool_free() > instead. > > Fixes: 0647398a8c7b ("mm: kmemleak: simple memory allocation pool for kmemleak objects") > Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Could you please reorder this patch before the previous one? If you added a Fixes tag, we may want a cc stable as well (as for the other patches with a Fixes tag) and it makes more sense to backport it on its own without the __create_object() split. Otherwise:
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
| |