lkml.org 
[lkml]   [2023]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 3/4] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2
From
On 18.10.23 13:34, Ingo Molnar wrote:
>
> * Juergen Gross <jgross@suse.com> wrote:
>
>> On 16.10.23 16:29, Peter Zijlstra wrote:
>>> On Mon, Oct 16, 2023 at 02:39:32PM +0200, Juergen Gross wrote:
>>>> Instead of stacking alternative and paravirt patching, use the new
>>>> ALT_FLAG_CALL flag to switch those mixed calls to pure alternative
>>>> handling.
>>>>
>>>> This eliminates the need to be careful regarding the sequence of
>>>> alternative and paravirt patching.
>>>>
>>>> For call depth tracking callthunks_setup() needs to be adapted to patch
>>>> calls at alternative patching sites instead of paravirt calls.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>
>>> I cannot help but feel this would've been better as two patches, one
>>> introducing ALT_NOT_XEN and then a second with the rest.
>>
>> In case I need to respin I'll split it up.
>
> Yeah, would be nice to split this patch into two, as Peter requested.

Okay, will resend the series probably tomorrow.


Juergen

[unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-10-18 17:03    [W:0.042 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site