Messages in this thread | | | Date | Wed, 18 Oct 2023 10:42:02 +0530 | Subject | Re: [PATCH v4 4/5] misc: fastrpc: Add support to save and restore interrupted | From | Ekansh Gupta <> |
| |
On 10/17/2023 9:40 PM, Greg KH wrote: > On Tue, Oct 17, 2023 at 08:36:28PM +0530, Ekansh Gupta wrote: >> On 10/17/2023 6:50 PM, Greg KH wrote: >>> On Tue, Oct 17, 2023 at 02:56:38PM +0530, Ekansh Gupta wrote: >>>> For any remote call, driver sends a message to DSP using RPMSG >>>> framework. After message is sent, there is a wait on a completion >>>> object at driver which is completed when DSP response is received. >>>> >>>> There is a possibility that a signal is received while waiting >>>> causing the wait function to return -ERESTARTSYS. In this case >>>> the context should be saved and it should get restored for the >>>> next invocation for the thread. >>>> >>>> Adding changes to support saving and restoring of interrupted >>>> fastrpc contexts. >>>> >>>> Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com> >>>> Change-Id: Ia101acf7c1bf6018635536082bf7ea009093c948 >>>> --- >>>> Changes in v2: >>>> - Fixed missing definition >>>> - Fixes compile time issue >>> You forgot to run checkpatch.pl :( >> I did run checkpatch.pl and also tried compilation test. checkpatch.pl is >> suggesting 0 errors, 0 warning and compilation also worked without any >> errors. I might have checked on last week's base as there were no changes in >> these files. I'll check the patches with latest version and update again if >> any errors/warnings are observed. Thanks for reviewing the patch. -ekansh > The "Change-Id:" should not be there, and I thought checkpatch would > catch that. If not, no big deal, you should have :)
Thanks for pointing this out, Greg. I'll update this with a new patch.
>
| |