lkml.org 
[lkml]   [2023]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] drm: mediatek: mtk_dsi: Fix NO_EOT_PACKET settings/handling
From
Il 15/09/23 12:11, Michael Walle ha scritto:
>> Due to the initial confusion about MIPI_DSI_MODE_EOT_PACKET, properly
>> renamed to MIPI_DSI_MODE_NO_EOT_PACKET, reflecting its actual meaning,
>> both the DSI_TXRX_CON register setting for bit (HSTX_)DIS_EOT and the
>> later calculation for horizontal sync-active (HSA), back (HBP) and
>> front (HFP) porches got incorrect due to the logic being inverted.
>>
>> This means that a number of settings were wrong because....:
>> - DSI_TXRX_CON register setting: bit (HSTX_)DIS_EOT should be
>> set in order to disable the End of Transmission packet;
>> - Horizontal Sync and Back/Front porches: The delta used to
>> calculate all of HSA, HBP and HFP should account for the
>> additional EOT packet.
>>
>> Before this change...
>> - Bit (HSTX_)DIS_EOT was being set when EOT packet was enabled;
>> - For HSA/HBP/HFP delta... all three were wrong, as words were
>> added when EOT disabled, instead of when EOT packet enabled!
>>
>> Invert the logic around flag MIPI_DSI_MODE_NO_EOT_PACKET in the
>> MediaTek DSI driver to fix the aforementioned issues.
>>
>> Fixes: 8b2b99fd7931 ("drm/mediatek: dsi: Fine tune the line time caused by EOTp")
>> Fixes: 2d52bfba09d1 ("drm/mediatek: add non-continuous clock mode and EOT packet control")
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>

Hello CK,

can you please pick this fix?

Thanks,
Angelo

\
 
 \ /
  Last update: 2023-10-18 12:22    [W:0.780 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site