lkml.org 
[lkml]   [2023]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ASoC: qcom: q6apm-lpass-dais: pass max number of channels to Audioreach
From
On 17/10/2023 18:14, Krzysztof Kozlowski wrote:
> Using the params_channels() helper when setting hw_params, results in
> passing to Audioreach minimum number of channels valid for given
> hardware. This is not valid for any hardware which sets minimum
> channels to two and maximum to something bigger, like four channels.
>
> Instead pass the maximum number of supported channels to allow playback
> of multi-channel formats.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 4 ++--

I am not sure if this is correct fix. I think sound machine drivers
should just not override channels like:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/soc/qcom/sm8250.c?h=v6.6-rc6#n44

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-10-18 10:14    [W:0.102 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site