lkml.org 
[lkml]   [2023]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2 1/5] net: stmmac: simplify debug message on stmmac_enable()
On Wed, Oct 18, 2023 at 09:09:53AM +0200, Johannes Zink wrote:
> Simplify the netdev_dbg() call in stmmac_enable() in order to reduce code
> duplication. No functional change.
>
> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>

Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
>
> ---
>
> Changelog:
>
> v1 -> v2: no changes
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> index 1be06b96c35f..f110b91af9bd 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> @@ -203,14 +203,10 @@ static int stmmac_enable(struct ptp_clock_info *ptp,
> /* Enable External snapshot trigger */
> acr_value |= priv->plat->ext_snapshot_num;
> acr_value |= PTP_ACR_ATSFC;
> - netdev_dbg(priv->dev, "Auxiliary Snapshot %d enabled.\n",
> - priv->plat->ext_snapshot_num >>
> - PTP_ACR_ATSEN_SHIFT);
> - } else {
> - netdev_dbg(priv->dev, "Auxiliary Snapshot %d disabled.\n",
> - priv->plat->ext_snapshot_num >>
> - PTP_ACR_ATSEN_SHIFT);
> }
> + netdev_dbg(priv->dev, "Auxiliary Snapshot %d %s.\n",
> + priv->plat->ext_snapshot_num >> PTP_ACR_ATSEN_SHIFT,
> + on ? "enabled" : "disabled");
> writel(acr_value, ptpaddr + PTP_ACR);
> mutex_unlock(&priv->aux_ts_lock);
> /* wait for auxts fifo clear to finish */
>
> --
> 2.39.2
>

\
 
 \ /
  Last update: 2023-10-18 20:05    [W:0.090 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site