lkml.org 
[lkml]   [2023]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7c 03/24] dyndbg: make ddebug_class_param union members same size
    Date
    struct ddebug_class_param keeps a ref to the state-storage of the
    param, make both flavors use the same unsigned long under-type.
    ISTM this is simpler and safer.

    Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
    ---
    include/linux/dynamic_debug.h | 2 +-
    lib/dynamic_debug.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
    index 4fcbf4d4fd0a..5231aaf361c4 100644
    --- a/include/linux/dynamic_debug.h
    +++ b/include/linux/dynamic_debug.h
    @@ -124,7 +124,7 @@ struct _ddebug_info {
    struct ddebug_class_param {
    union {
    unsigned long *bits;
    - unsigned int *lvl;
    + unsigned long *lvl;
    };
    char flags[8];
    const struct ddebug_class_map *map;
    diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
    index ceb3067a5c83..b984ce338921 100644
    --- a/lib/dynamic_debug.c
    +++ b/lib/dynamic_debug.c
    @@ -796,7 +796,7 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp)

    case DD_CLASS_TYPE_LEVEL_NAMES:
    case DD_CLASS_TYPE_LEVEL_NUM:
    - return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl);
    + return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl);
    default:
    return -1;
    }
    --
    2.41.0
    \
     
     \ /
      Last update: 2023-10-18 19:07    [W:4.099 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site