Messages in this thread | | | From | Yu Zhao <> | Date | Wed, 18 Oct 2023 10:21:47 -0600 | Subject | Re: [PATCH 2/2] mm: multi-gen lru: fix stat count |
| |
On Wed, Oct 18, 2023 at 2:22 AM Huan Yang <link@vivo.com> wrote: > > For multi-gen lru reclaim in evict_folios, like shrink_inactive_list, > gather folios which isolate to reclaim, and invoke shirnk_folio_list. > > But, when complete shrink, it not gather shrink reclaim stat into sc, > we can't get info like nr_dirty\congested in reclaim, and then > control writeback, dirty number and mark as LRUVEC_CONGESTED, or > just bpf trace shrink and get correct sc stat. > > This patch fix this by simple copy code from shrink_inactive_list when > end of shrink list.
MGLRU doesn't try to write back dirt file pages in the reclaim path -- it filters them out in sort_folio() and leaves them to the page writeback. (The page writeback is a dedicated component for this purpose). So there is nothing to fix.
| |