lkml.org 
[lkml]   [2023]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/7] drm/msm/adreno: Add ZAP firmware name to A635
    From


    On 10/17/23 09:33, Rob Clark wrote:
    > On Mon, Oct 16, 2023 at 1:12 PM Akhil P Oommen <quic_akhilpo@quicinc.com> wrote:
    >>
    >> On Tue, Sep 26, 2023 at 08:24:37PM +0200, Konrad Dybcio wrote:
    >>>
    >>> Some (many?) devices with A635 expect a ZAP shader to be loaded.
    >>>
    >>> Set the file name to allow for that.
    >>>
    >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
    >>> ---
    >>> drivers/gpu/drm/msm/adreno/adreno_device.c | 1 +
    >>> 1 file changed, 1 insertion(+)
    >>>
    >>> diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
    >>> index fa527935ffd4..16527fe8584d 100644
    >>> --- a/drivers/gpu/drm/msm/adreno/adreno_device.c
    >>> +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
    >>> @@ -454,6 +454,7 @@ static const struct adreno_info gpulist[] = {
    >>> .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
    >>> ADRENO_QUIRK_HAS_HW_APRIV,
    >>> .init = a6xx_gpu_init,
    >>> + .zapfw = "a660_zap.mbn",
    >>
    >> sc7280 doesn't have a TZ and so no zap shader support. Can we handle
    >> this using "firmware-name" property in your top level platform dt? Zap
    >> firmwares are signed with different keys for each OEMs. So there is
    >> cross-compatibility anyway.
    >
    > I think this ends up working out because the version of sc7280 that
    > doesn't have TZ also doesn't have the associated mem-region/etc..
    Yes

    > but
    > maybe we should deprecate the zapfw field as in practice it isn't
    > useful (ie. always overriden by firmware-name).
    Also yes, we've discussed that on IRC once

    >
    > Fwiw there are windows laptops with sc7180/sc7280 which do use zap fw.
    Correct, e.g. the SC7180 Acer Aspire 1 that is supported upstream.

    Konrad

    Konrad

    \
     
     \ /
      Last update: 2023-10-17 17:42    [W:4.298 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site