Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Tue, 17 Oct 2023 14:44:25 +0200 | Subject | Re: [PATCH v3 54/73] pinctrl: intel: drop the wrappers around pinctrl_gpio_direction_input() |
| |
On Tue, 17 Oct 2023 at 14:41, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Tue, Oct 17, 2023 at 02:04:12PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > pinctrl_gpio_direction_input() now has the same signature as the > > wrappers around it so we can drop them. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Now, for the sake of symmetry can you add (at least to the all > Intel drivers you modified in this series) the following: >
Good idea but this is v6.8 material, I don't want to extend this series anymore at this point.
Bart
> > int pinctrl_gpio_direction_output_with_value(struct gpio_chip *gc, > unsigned int offset, int value) > { > gc->set(gc, offset, value); > return pinctrl_gpio_direction_output(gc, offset); > } > > > ? > > And respectively in this driver > > .direction_output = pincttl_gpio_direction_output_with_value, > > > -- > With Best Regards, > Andy Shevchenko > >
| |