lkml.org 
[lkml]   [2023]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2 00/11] devlink: retain error in struct devlink_fmsg
Tue, Oct 17, 2023 at 12:53:30PM CEST, przemyslaw.kitszel@intel.com wrote:
>Extend devlink fmsg to retain error (patch 1),
>so drivers could omit error checks after devlink_fmsg_*() (patches 2-10),
>and finally enforce future uses to follow this practice by change to
>return void (patch 11)
>
>Note that it was compile tested only.
>
>bloat-o-meter for whole series:
>add/remove: 8/18 grow/shrink: 23/40 up/down: 2017/-5833 (-3816)
>
>changelog:
>v2: extend series by two more drivers (qed, qlge);
> add final cleanup patch, since now whole series should be merged in
> one part (thanks Jiri for encouragement here);
>
>v1:
>https://lore.kernel.org/netdev/20231010104318.3571791-3-przemyslaw.kitszel@intel.com
>
>Przemek Kitszel (11):
> devlink: retain error in struct devlink_fmsg
> netdevsim: devlink health: use retained error fmsg API
> pds_core: devlink health: use retained error fmsg API
> bnxt_en: devlink health: use retained error fmsg API
> hinic: devlink health: use retained error fmsg API
> octeontx2-af: devlink health: use retained error fmsg API
> mlxsw: core: devlink health: use retained error fmsg API
> net/mlx5: devlink health: use retained error fmsg API
> qed: devlink health: use retained error fmsg API
> staging: qlge: devlink health: use retained error fmsg API
> devlink: convert most of devlink_fmsg_*() to return void

Looks great.

Thanks!

set-
Reviewed-by: Jiri Pirko <jiri@nvidia.com>

\
 
 \ /
  Last update: 2023-10-17 13:20    [W:0.156 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site