Messages in this thread | | | Date | Tue, 17 Oct 2023 10:43:00 +0200 | From | Markus Schneider-Pargmann <> | Subject | Re: [PATCH] thermal/drivers/mediatek: Fix probe for THERMAL_V2 |
| |
Hi Daniel,
On Mon, Sep 18, 2023 at 12:07:06PM +0200, Markus Schneider-Pargmann wrote: > Fix the probe function to call mtk_thermal_release_periodic_ts for > everything != MTK_THERMAL_V1. This was accidentally changed from V1 > to V2 in the original patch. > > Reported-by: Frank Wunderlich <frank-w@public-files.de> > Closes: https://lore.kernel.org/lkml/B0B3775B-B8D1-4284-814F-4F41EC22F532@public-files.de/ > Reported-by: Daniel Lezcano <daniel.lezcano@linaro.org> > Closes: https://lore.kernel.org/lkml/07a569b9-e691-64ea-dd65-3b49842af33d@linaro.org/ > Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks") > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Did you have a chance to have a look at this fix and the other one for auxadc_thermal? https://lore.kernel.org/linux-arm-kernel/20230907112018.52811-1-linux@fw-web.de/
Thanks!
Best, Markus
> --- > drivers/thermal/mediatek/auxadc_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c > index 843214d30bd8..8b0edb204844 100644 > --- a/drivers/thermal/mediatek/auxadc_thermal.c > +++ b/drivers/thermal/mediatek/auxadc_thermal.c > @@ -1267,7 +1267,7 @@ static int mtk_thermal_probe(struct platform_device *pdev) > > mtk_thermal_turn_on_buffer(mt, apmixed_base); > > - if (mt->conf->version != MTK_THERMAL_V2) > + if (mt->conf->version != MTK_THERMAL_V1) > mtk_thermal_release_periodic_ts(mt, auxadc_base); > > if (mt->conf->version == MTK_THERMAL_V1) > -- > 2.40.1 >
| |