| Subject | Re: [PATCH v2 05/19] riscv: add ISA extension parsing for vector crypto extensions | From | Jerry Shih <> | Date | Wed, 18 Oct 2023 09:45:30 +0800 |
| |
On Oct 17, 2023, at 21:14, Clément Léger <cleger@rivosinc.com> wrote: > @@ -221,6 +261,22 @@ const struct riscv_isa_ext_data riscv_isa_ext[] = { > __RISCV_ISA_EXT_DATA(zkt, RISCV_ISA_EXT_ZKT), > __RISCV_ISA_EXT_DATA(zksed, RISCV_ISA_EXT_ZKSED), > __RISCV_ISA_EXT_DATA(zksh, RISCV_ISA_EXT_ZKSH), > + __RISCV_ISA_EXT_DATA(zvbb, RISCV_ISA_EXT_ZVBB), > + __RISCV_ISA_EXT_DATA(zvbc, RISCV_ISA_EXT_ZVBC), > + __RISCV_ISA_EXT_DATA(zvkb, RISCV_ISA_EXT_ZVKB),
The `Zvkb` is the subset of `Zvbb`[1]. So, the `Zvkb` should be bundled with `Zvbb`.
+ __RISCV_ISA_EXT_DATA(zvbb, RISCV_ISA_EXT_ZVBB), + __RISCV_ISA_EXT_DATA(zvbb, RISCV_ISA_EXT_ZVKB), + __RISCV_ISA_EXT_DATA(zvkb, RISCV_ISA_EXT_ZVKB),
or
+ __RISCV_ISA_EXT_BUNDLE(zvbb, riscv_zvbb_bundled_exts), + __RISCV_ISA_EXT_DATA(zvkb, RISCV_ISA_EXT_ZVKB),
[1] https://github.com/riscv/riscv-crypto/blob/main/doc/vector/riscv-crypto-vector-zvkb.adoc
-Jerry
|