Messages in this thread | | | Date | Tue, 17 Oct 2023 16:43:45 -0400 | From | Frank Li <> | Subject | Re: [PATCH 3/5] i3c: svc: rename read_len as actual_len |
| |
On Tue, Oct 17, 2023 at 04:07:29PM +0200, Miquel Raynal wrote: > Hi Frank, > > Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:46:30 -0400: > > > I3C transfer, target can early terminate transfer. > > I2C transfer, target can NACK write transfer. > > > > 'actual_len' is better name than 'read_len'. > > I don't find read_len confusing because it may mean "how much bytes > were actually read" rather than "how much we need to read". But if > actual_len sounds better, I'm fine.
Another reason: According to i3c spec. 5.2.2.3.6 line 6090. Target ends or continues the write transfer.
in HDR mode, target can end write transfer. So use 'actual_len'
Do you think I need add it to commit message
Frank
> > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > Thanks, > Miquèl
| |