Messages in this thread | | | Date | Mon, 16 Oct 2023 07:59:22 +0200 | Subject | Re: [PATCH] ath5k: replace deprecated strncpy with strscpy | From | Jiri Slaby <> |
| |
On 13. 10. 23, 22:53, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We expect led->name to be NUL-terminated based on the presence of a > manual NUL-byte assignment. > > This NUL-byte assignment was added in Commit daf9669bea30aa22 ("ath5k: > ensure led name is null terminated"). If strscpy() had existed and had > been used back when this code was written then potential bugs and the > need to manually NUL-terminate could have been avoided. Since we now > have the technology, let's use it :) > > Considering the above, a suitable replacement is `strscpy` [2] due to > the fact that it guarantees NUL-termination on the destination buffer > without unnecessarily NUL-padding. If NUL-padding is required let's opt > for strscpy_pad(). > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@vger.kernel.org > Signed-off-by: Justin Stitt <justinstitt@google.com>
LGTM Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
-- js suse labs
| |