Messages in this thread | | | Date | Mon, 16 Oct 2023 14:32:25 +0200 | Subject | Re: [PATCH v3 1/4] tty: whitespaces in descriptions corrected by replacing tabs with spaces. | From | Jiri Slaby <> |
| |
On 16. 10. 23, 9:13, Florian Eckert wrote: > Tabs were used in the function description, to make this look more > uniform, the tabs were replaced by spaces where necessary. > > Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
LGTM (spihnx prefers spaces), except:
> @@ -3470,7 +3470,7 @@ int tty_register_driver(struct tty_driver *driver) > EXPORT_SYMBOL(tty_register_driver); > > /** > - * tty_unregister_driver -- unregister a tty driver > + * tty_unregister_driver - unregister a tty driver
you should have noted you changed ndashes to dashes too. (As only the latter is supported by sphinx.)
thanks, -- js suse labs
| |