Messages in this thread | | | Date | Fri, 13 Oct 2023 10:16:46 -0700 | Subject | Re: [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET | From | Jacob Keller <> |
| |
On 10/12/2023 4:31 PM, Jakub Kicinski wrote: > On Thu, 12 Oct 2023 18:34:00 +0000 Keller, Jacob E wrote: >>> Even if this is just > v6.6 kernels (i.e., linux-next), >>> it would be very good to get a fix merged for these build errors. >>> I keep getting build errors in linux-next.... >> >> A standalone version for the idpf driver fix was posted at [1], and >> another alternative fix was posted at [2] >> >> Fixes for the ice driver have already merged. >> >> [1]: >> https://lore.kernel.org/netdev/20230921125936.1621191-1-aleksander.lobakin@intel.com/ >> [2]: >> https://lore.kernel.org/netdev/20230925155858.651425-1-arnd@kernel.org/ >> >> The fix from Arnd got approval from Olek, but it seems like it >> stalled out after asking about stubs. I'm fine with either approach >> but would also like to see a fix merge soon. > > The suggestion of making NET == INET is quite tempting but requires > extra consideration. Since nobody seems to have the cycles, let's > go with the stubs? >
Yea. I think NET == INET would cause a bit more challenge in the immediate term. Its possibly worth exploring but it would be nice to get the build bots happy first.
I can take the time this morning to work on a version that implements the stub, and post it.
Thanks, Jake
| |