Messages in this thread | | | Date | Fri, 13 Oct 2023 14:22:52 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: phy: tja11xx: replace deprecated strncpy with ethtool_sprintf |
| |
> - for (i = 0; i < ARRAY_SIZE(tja11xx_hw_stats); i++) { > - strncpy(data + i * ETH_GSTRING_LEN, > - tja11xx_hw_stats[i].string, ETH_GSTRING_LEN); > - } > + for (i = 0; i < ARRAY_SIZE(tja11xx_hw_stats); i++) > + ethtool_sprintf(&data, "%s", tja11xx_hw_stats[i].string); > }
I assume you are using "%s" because tja11xx_hw_stats[i].string cannot be trusted as a format string? Is this indicating we need an ethtool_puts() ?
Andrew
| |