Messages in this thread | | | From | Niklas Cassel <> | Subject | Re: [PATCH v2] nvme: update firmware version after commit | Date | Fri, 13 Oct 2023 19:43:21 +0000 |
| |
On Fri, Oct 13, 2023 at 10:43:48AM -0600, Keith Busch wrote: > On Fri, Oct 13, 2023 at 06:34:20PM +0200, Daniel Wagner wrote: > > if (nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_FW_SLOT, 0, NVME_CSI_NVM, > > - log, sizeof(*log), 0)) > > + log, sizeof(*log), 0)) { > > dev_warn(ctrl->device, "Get FW SLOT INFO log error\n"); > > + goto out_free_log; > > + } > > + > > + afi = le64_to_cpu(log->afi); > > + if (afi & 0x30) { > > That should be 'afi & 0x70'.
Personally, I like GENMASK(). In this specific case it would be GENMASK_ULL(6, 4);
I find that more readable than 0x70. Although for some reason GENMASK()/GENMASK_ULL() does not seem to be used in drivers/nvme/
Kind regards, Niklas
| |