Messages in this thread | | | From | Nick Terrell <> | Subject | Re: [PATCH] lib: zstd: remove unneeded variable | Date | Thu, 12 Oct 2023 15:57:39 +0000 |
| |
> On Jun 14, 2023, at 3:14 AM, baomingtong001@208suo.com wrote: > > !-------------------------------------------------------------------| > This Message Is From an Untrusted Sender > You have not previously corresponded with this sender. > |-------------------------------------------------------------------! > > fix the following coccicheck warning: > > lib/zstd/compress/zstd_cwksp.h:220:17-27: Unneeded variable: "slackSpace". Return "ZSTD_CWKSP_ALIGNMENT_BYTES".
If you would like to fix this, please fix this upstream at https://github.com/facebook/zstd. That will get synced to the kernel on the next update.
Thanks, Nick Terrell
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com> > --- > lib/zstd/compress/zstd_cwksp.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/zstd/compress/zstd_cwksp.h b/lib/zstd/compress/zstd_cwksp.h > index 349fc923c355..36c574cd3d6f 100644 > --- a/lib/zstd/compress/zstd_cwksp.h > +++ b/lib/zstd/compress/zstd_cwksp.h > @@ -217,8 +217,7 @@ MEM_STATIC size_t ZSTD_cwksp_slack_space_required(void) { > * n_1 + n_2 == 64 bytes if the cwksp is freshly allocated, due to tables and > * aligneds being sized in multiples of 64 bytes. > */ > - size_t const slackSpace = ZSTD_CWKSP_ALIGNMENT_BYTES; > - return slackSpace; > + return ZSTD_CWKSP_ALIGNMENT_BYTES; > }
[unhandled content-type:application/ms-tnef]
| |