lkml.org 
[lkml]   [2023]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2 2/2] dt-bindings: net: microchip,ksz: document microchip,rmii-clk-internal
On Thu, Oct 12, 2023 at 12:55:56PM +0200, Ante Knezic wrote:
> Add documentation for selecting reference rmii clock on KSZ88X3 devices
>
> Signed-off-by: Ante Knezic <ante.knezic@helmholz.de>
> ---
> .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index 41014f5c01c4..eaa347b04db1 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> @@ -72,6 +72,25 @@ properties:
> interrupts:
> maxItems: 1
>
> + microchip,rmii-clk-internal:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + Set if the RMII reference clock is provided internally. Otherwise
> + reference clock should be provided externally.

I regret not asking this on the previous iteration - how come you need a
custom property? In the externally provided case would there not be a
clocks property pointing to the RMII reference clock, that would be
absent when provided by the itnernal reference?

Cheers,
Conor.

> +
> +if:
> + not:
> + properties:
> + compatible:
> + enum:
> + - microchip,ksz8863
> + - microchip,ksz8873
> +then:
> + not:
> + required:
> + - microchip,rmii-clk-internal
> +
> +
> required:
> - compatible
> - reg
> --
> 2.11.0
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-10-12 17:19    [W:0.104 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site