lkml.org 
[lkml]   [2023]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 1/4] HID: core: remove #ifdef CONFIG_PM from hid_driver
    Allow HID drivers to pass ->suspend, ->resume and ->reset_resume via
    pm_ptr().
    Through the usage of pm_ptr() the CONFIG_PM-dependent code will always be
    compiled, protecting against bitrot.
    The linker will then garbage-collect the unused function avoiding any overhead.

    The only overhead in the final kernel image and at runtime are a few
    extra bytes in 'struct hid_driver'.

    The same approach is chosen by 'struct usb_driver' and other subsystems.

    Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
    ---
    include/linux/hid.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/include/linux/hid.h b/include/linux/hid.h
    index 964ca1f15e3f..5a8387a4a712 100644
    --- a/include/linux/hid.h
    +++ b/include/linux/hid.h
    @@ -833,11 +833,11 @@ struct hid_driver {
    void (*feature_mapping)(struct hid_device *hdev,
    struct hid_field *field,
    struct hid_usage *usage);
    -#ifdef CONFIG_PM
    +
    int (*suspend)(struct hid_device *hdev, pm_message_t message);
    int (*resume)(struct hid_device *hdev);
    int (*reset_resume)(struct hid_device *hdev);
    -#endif
    +
    /* private: */
    struct device_driver driver;
    };
    --
    2.42.0

    \
     
     \ /
      Last update: 2023-10-12 12:25    [W:2.148 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site