lkml.org 
[lkml]   [2023]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] memblock: don't run loop in memblock_add_range() twice
On Thu, Oct 05, 2023 at 11:20:19PM +0800, Yajun Deng wrote:
>
> On 2023/10/5 13:19, Mike Rapoport wrote:
>
> > I don't see this micro-optimization is worth the churn and potential bugs.
> > NAK.
>
> There are many handouts that tell people it needs to run twice in
> memblock_add_range().
>
> I think it's time to change this. I'm trying to tell people that running
> twice is unnecessary.

It might be unnecessary, but it's still simpler than the solutions you
proposed. And, again, removing the second loop is not worth the churn and
potential bugs.

--
Sincerely yours,
Mike.

\
 
 \ /
  Last update: 2023-10-12 11:26    [W:0.046 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site