Messages in this thread | | | Date | Thu, 12 Oct 2023 09:54:03 +0200 | Subject | Re: [PATCH v2 1/5] dt-bindings: media: Document STM32MP25 VDEC & VENC video codecs | From | Hugues FRUCHET <> |
| |
Hi Conor,
Will do all in v3, thanks !
On 10/11/23 17:55, Conor Dooley wrote: > Hey, > > On Tue, Oct 10, 2023 at 11:16:39AM +0200, Hugues Fruchet wrote: >> Add STM32MP25 VDEC video decoder & VENC video encoder bindings. >> >> Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com> >> --- >> .../media/st,stm32mp25-video-codec.yaml | 58 +++++++++++++++++++ >> 1 file changed, 58 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml >> >> diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml >> new file mode 100644 >> index 000000000000..479566171568 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml >> @@ -0,0 +1,58 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> + >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/st,stm32mp25-video-codec.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: STMicroelectronics STM32MP25 VDEC video decoder & VENC video encoder >> + >> +maintainers: >> + - Hugues Fruchet <hugues.fruchet@foss.st.com> >> + >> +description: >> + The STMicroelectronics STM32MP25 SOCs embeds a VDEC video hardware >> + decoder peripheral based on Verisilicon VC8000NanoD IP (former Hantro G1) >> + and a VENC video hardware encoder peripheral based on Verisilicon >> + VC8000NanoE IP (former Hantro H1). >> + >> +properties: >> + compatible: >> + items: > > This "items:" is not needed, the enum on its own is enough. > >> + - enum: >> + - st,stm32mp25-vdec >> + - st,stm32mp25-venc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + vdec: video-codec@580d0000 { > > The node labels for both nodes here are not used & should be dropped. > > Otherwise, this seems fine to me. > > Cheers, > Conor. > >> + compatible = "st,stm32mp25-vdec"; >> + reg = <0x580d0000 0x3c8>; >> + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ck_icn_p_vdec>; >> + }; >> + - | >> + venc: video-codec@580e0000 { >> + compatible = "st,stm32mp25-venc"; >> + reg = <0x580e0000 0x800>; >> + interrupts = <GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ck_icn_p_venc>; >> + }; >> -- >> 2.25.1 >>
BR, Hugues.
| |