Messages in this thread | | | Date | Thu, 12 Oct 2023 09:24:36 +0200 | Subject | Re: [PATCH 3/5] parisc: remove broken vdso_install | From | Helge Deller <> |
| |
Hi Masahiro,
On 10/9/23 14:42, Masahiro Yamada wrote: > 'make ARCH=parisc vdso_install' has never worked. It attempts to > descend into arch/parisc/kernel/vdso/, which does not exist. > > The command just fails: > > scripts/Makefile.build:41: arch/parisc/kernel/vdso/Makefile: No such file or directory > > The second line is also meaningless because parisc does not define > CONFIG_COMPAT_VDSO. > > It appears that this code was copied from another architecture without > proper adaptation.
Yes.
> Remove the broken code. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Thanks for cleaning this up and making it consistent across the architectures.
Acked-by: Helge Deller <deller@gmx.de> # parisc
In case you do a v2 version of the patch, would you add to arch/parisc/Makefile (otherwise I can send a follow-up patch in the parisc git tree):
vdso-install-y += arch/parisc/kernel/vdso32/vdso32.so vdso-install-$(CONFIG_64BIT) += arch/parisc/kernel/vdso64/vdso64.so
Thanks! Helge
| |