Messages in this thread | | | Date | Thu, 12 Oct 2023 09:52:48 -1000 | From | Tejun Heo <> | Subject | Re: [PATCH] workqueue: Override implicit ordered attribute in workqueue_apply_unbound_cpumask() |
| |
On Tue, Oct 10, 2023 at 10:48:42PM -0400, Waiman Long wrote: > Commit 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 > to be ordered") enabled implicit ordered attribute to be added to > WQ_UNBOUND workqueues with max_active of 1. This prevented the changing > of attributes to these workqueues leading to fix commit 0a94efb5acbb > ("workqueue: implicit ordered attribute should be overridable"). > > However, workqueue_apply_unbound_cpumask() was not updated at that time. > So sysfs changes to wq_unbound_cpumask has no effect on WQ_UNBOUND > workqueues with implicit ordered attribute. Since not all WQ_UNBOUND > workqueues are visible on sysfs, we are not able to make all the > necessary cpumask changes even if we iterates all the workqueue cpumasks > in sysfs and changing them one by one. > > Fix this problem by applying the corresponding change made > to apply_workqueue_attrs_locked() in the fix commit to > workqueue_apply_unbound_cpumask(). > > Fixes: 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be ordered") > Signed-off-by: Waiman Long <longman@redhat.com>
Applied to wq/for-6.6-fixes.
Thanks.
-- tejun
| |