Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 11 Oct 2023 18:18:19 +0300 | Subject | Re: [PATCH 3/3] i2c: mux: gpio: don't fiddle with GPIOLIB internals |
| |
On Wed, Oct 11, 2023 at 5:59 PM Peter Rosin <peda@axentia.se> wrote: > 2023-10-11 at 15:02, Bartosz Golaszewski wrote:
> > Use the relevant API functions to retrieve the address of the > > underlying struct device instead of accessing GPIOLIB private structures > > manually.
> Very nice to see that wart gone! The only small question I have > is if these helpers are needed elsewhere, or if a more "direct" > gpiod_to_device() would have been sufficient?
Same concern is here. But I'm fine with the code.
-- With Best Regards, Andy Shevchenko
| |