Messages in this thread | | | Date | Wed, 11 Oct 2023 15:25:45 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] mm/list_lru: Remove unused function |
| |
On (23/09/22 18:07), Jiapeng Chong wrote: > The function are defined in the list_lru.c file, but not called > elsewhere, so delete the unused function. > > mm/list_lru.c:64:1: warning: unused function 'list_lru_from_kmem'.
It seems that this breaks linux-next bisectability:
---
mm/list_lru.c:98:7: error: implicit declaration of function 'list_lru_from_kmem' is invalid in C99 [-Werror,-Wimplicit-function-declaration] l = list_lru_from_kmem(lru, nid, item, &memcg); ^ mm/list_lru.c:98:5: warning: incompatible integer to pointer conversion assigning to 'struct list_lru_one *' from 'int' [-Wint-conversion] l = list_lru_from_kmem(lru, nid, item, &memcg); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mm/list_lru.c:121:7: error: implicit declaration of function 'list_lru_from_kmem' is invalid in C99 [-Werror,-Wimplicit-function-declaration] l = list_lru_from_kmem(lru, nid, item, NULL); ^ mm/list_lru.c:121:5: warning: incompatible integer to pointer conversion assigning to 'struct list_lru_one *' from 'int' [-Wint-conversion] l = list_lru_from_kmem(lru, nid, item, NULL); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings and 2 errors generated.
| |