Messages in this thread | | | Date | Wed, 11 Oct 2023 22:35:23 +0800 | From | kernel test robot <> | Subject | Re: [PATCH net-next v1 2/3] net: dsa: microchip: ksz8: Enable MIIM PHY Control reg access |
| |
Hi Oleksij,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Oleksij-Rempel/net-dsa-microchip-ksz8-Enable-MIIM-PHY-Control-reg-access/20231011-204502 base: net-next/main patch link: https://lore.kernel.org/r/20231011123856.1443308-2-o.rempel%40pengutronix.de patch subject: [PATCH net-next v1 2/3] net: dsa: microchip: ksz8: Enable MIIM PHY Control reg access config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231011/202310112224.iYgvjBUy-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231011/202310112224.iYgvjBUy-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202310112224.iYgvjBUy-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/dsa/microchip/ksz8795.c:646: warning: Function parameter or member 'val' not described in 'ksz8_r_phy_ctrl'
vim +646 drivers/net/dsa/microchip/ksz8795.c
634 635 /** 636 * ksz8_r_phy_ctrl - Translates and reads from the SMI interface to a MIIM PHY 637 * Control register (Reg. 31). 638 * @dev: The KSZ device instance. 639 * @port: The port number to be read. 640 * 641 * This function reads the SMI interface and translates the hardware register 642 * bit values into their corresponding control settings for a MIIM PHY Control 643 * register. 644 */ 645 static int ksz8_r_phy_ctrl(struct ksz_device *dev, int port, u16 *val) > 646 { 647 const u16 *regs = dev->info->regs; 648 u8 reg_val; 649 int ret; 650 651 *val = 0; 652 653 ret = ksz_pread8(dev, port, regs[P_LINK_STATUS], ®_val); 654 if (ret < 0) 655 return ret; 656 657 if (reg_val & PORT_MDIX_STATUS) 658 *val |= KSZ886X_CTRL_MDIX_STAT; 659 660 ret = ksz_pread8(dev, port, REG_PORT_LINK_MD_CTRL, ®_val); 661 if (ret < 0) 662 return ret; 663 664 if (reg_val & PORT_FORCE_LINK) 665 *val |= KSZ886X_CTRL_FORCE_LINK; 666 667 if (reg_val & PORT_POWER_SAVING) 668 *val |= KSZ886X_CTRL_PWRSAVE; 669 670 if (reg_val & PORT_PHY_REMOTE_LOOPBACK) 671 *val |= KSZ886X_CTRL_REMOTE_LOOPBACK; 672 673 return 0; 674 } 675
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
| |