Messages in this thread | | | Date | Wed, 11 Oct 2023 05:20:59 -0700 | From | Breno Leitao <> | Subject | Re: [PATCH v4] x86/bugs: Add a separate config for each mitigation |
| |
On Tue, Oct 10, 2023 at 09:42:52PM -0700, Josh Poimboeuf wrote: > On Tue, Oct 10, 2023 at 03:30:27AM -0700, Breno Leitao wrote: > > +config MITIGATE_MDS > > + bool "Mitigate Microarchitectural Data Sampling (MDS) hardware bug" > > + depends on CPU_SUP_INTEL > > + default y > > + help > > + Enable mitigation for Microarchitectural Data Sampling (MDS). MDS is > > + a hardware vulnerability which allows unprivileged speculative access > > + to data which is available in various CPU internal buffer. Deeper > > + technical information is available in the MDS specific x86 architecture > > + section: Documentation/arch/x86/mds.rst. > > MITIGATE_GDS seems to be missing?
GDS is named `GDS_FORCE_MITIGATION` instead of MITIGATE_GDS. See 11cf22869ea ("x86/speculation: Add Kconfig option for GDS") > > For consistency I'm thinking it would be better to call them > MITIGATION_* rather than MITIGATE_* since they're under the > SPECULATION_MITIGATIONS menuentry, and the bugs code almost exclusively > uses the noun "mitigation" rather than the verb "mitigate".
Sure. I can definitely rename them to MITIGATION_. Let's see if no one else disagree and I will update the patch.
> While we're at it should we go ahead and rename the existing options?
Sure!
Thanks for the feedback!
| |