| Date | Wed, 11 Oct 2023 11:50:50 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 01/10] PCI: Use FIELD_GET() |
| |
On Tue, 10 Oct 2023 15:44:27 -0500 Bjorn Helgaas <helgaas@kernel.org> wrote:
> From: Bjorn Helgaas <bhelgaas@google.com> > > Use FIELD_GET() to remove dependences on the field position, i.e., the > shift value. No functional change intended. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
It's a little unfortunate that some of the masks are called *_MASK and others are not (e.g. PCI_RBAR_CTRL_BAR_SIZE which is a mask). but given they are in include/uapi not sure we can tidy that up unless we add more defines that stick to consistent naming...
Otherwise very nice.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
|