Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 11 Oct 2023 09:59:56 +0200 | Subject | Re: [PATCH 4/8] drm/ssd13xx: Use drm_format_info_min_pitch() to calculate the dest_pitch |
| |
Hi Javier,
On Mon, Oct 9, 2023 at 8:36 PM Javier Martinez Canillas <javierm@redhat.com> wrote: > Don't assume bpp of 1 and instead compute the destination pitch using the > intermediate buffer pixel format info when doing a format conversion. > > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks for your patch!
> --- a/drivers/gpu/drm/solomon/ssd13xx.c > +++ b/drivers/gpu/drm/solomon/ssd13xx.c > @@ -148,6 +148,8 @@ struct ssd13xx_plane_state { > struct drm_shadow_plane_state base; > /* Intermediate buffer to convert pixels from XRGB8888 to HW format */ > u8 *buffer; > + /* Pixel format info for the intermediate buffer */ > + const struct drm_format_info *fi;
This is really intermediate, as it is removed again in the next patch :-)
In fact 60% of this patch is changed again in the next patch. So perhaps combine this with the next patch?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |