lkml.org 
[lkml]   [2023]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 03/14] bitops: let the compiler optimize __assign_bit()
From
From: Yury Norov <yury.norov@gmail.com>
Date: Mon, 9 Oct 2023 09:18:40 -0700

> On Mon, Oct 09, 2023 at 05:10:15PM +0200, Alexander Lobakin wrote:

[...]

>> -static __always_inline void __assign_bit(long nr, volatile unsigned long *addr,
>> - bool value)
>> -{
>> - if (value)
>> - __set_bit(nr, addr);
>> - else
>> - __clear_bit(nr, addr);
>> -}
>> +#define __assign_bit(nr, addr, value) \
>> + ((value) ? __set_bit(nr, addr) : __clear_bit(nr, addr))
>
> Can you protect nr and addr with braces just as well?
> Can you convert the atomic version too, to keep them synchronized ?

+ for both. I didn't convert assign_bit() as I thought it wouldn't give
any optimization improvements, but yeah, let the compiler decide.

>
>>
>> /**
>> * __ptr_set_bit - Set bit in a pointer's value
>> --
>> 2.41.0

Thanks,
Olek

\
 
 \ /
  Last update: 2023-10-11 09:28    [W:0.077 / U:1.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site