Messages in this thread | | | Date | Wed, 11 Oct 2023 16:30:27 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] ionic: replace deprecated strncpy with strscpy |
| |
On Wed, Oct 11, 2023 at 09:53:44PM +0000, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > NUL-padding is not needed due to `ident` being memset'd to 0 just before > the copy. > > Considering the above, a suitable replacement is `strscpy` [2] due to > the fact that it guarantees NUL-termination on the destination buffer > without unnecessarily NUL-padding. > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@vger.kernel.org > Signed-off-by: Justin Stitt <justinstitt@google.com>
Yup, looks like a direct replacement.
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |