lkml.org 
[lkml]   [2023]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 3/4] hte: tegra194: Remove redundant dev_err()
    Date
    There is no need to call the dev_err() function directly to print a custom
    message when handling an error from platform_get_irq() function as it is
    going to display an appropriate error message in case of a failure.

    Reviewed-by: Dipen Patel <dipenp@nvidia.com>
    Tested-by: Dipen Patel <dipenp@nvidia.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Link: https://lore.kernel.org/r/20231010151709.4104747-4-andriy.shevchenko@linux.intel.com
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/hte/hte-tegra194.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
    index f6c2dbcd0aca..cf6058193403 100644
    --- a/drivers/hte/hte-tegra194.c
    +++ b/drivers/hte/hte-tegra194.c
    @@ -731,10 +731,8 @@ static int tegra_hte_probe(struct platform_device *pdev)
    return -ENOMEM;

    ret = platform_get_irq(pdev, 0);
    - if (ret < 0) {
    - dev_err_probe(dev, ret, "failed to get irq\n");
    + if (ret < 0)
    return ret;
    - }
    hte_dev->hte_irq = ret;
    ret = devm_request_irq(dev, hte_dev->hte_irq, tegra_hte_isr, 0,
    dev_name(dev), hte_dev);
    --
    2.40.0.1.gaa8946217a0b
    \
     
     \ /
      Last update: 2023-10-11 22:27    [W:2.869 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site