lkml.org 
[lkml]   [2023]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 00/62] pinctrl: don't use GPIOLIB global numberspace in helpers
On Wed, Oct 11, 2023 at 02:07:28PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> We have a set of pinctrl helpers for GPIOLIB drivers that take a number
> from the global GPIO numberspace as argument. We are trying to get rid
> of this global numbering. Let's rework these helpers to use the
> recommended gpio_chip + controller-relative offset instead.
>
> This work is split into phases: first let's introduce the new variants
> of the helpers. Next: let's convert all users one-by-one for easier
> review. After that let's remove the old helpers and rename the new
> variants to take the place of the old ones. Finally convert static
> functions in pinctrl/core.c to using the same signature and to top it
> off, let's remove now redundant wrappers around the pinctrl_helpers.
>
> This series introduces no functional changes in drivers so I decided to
> not spam every single driver maintainer anymore.

...

> pinctrl: intel: use new pinctrl GPIO helpers

If it's going to be a separate patch at the end, please split it even more, so
we will have a lean history for each driver.

...

> pinctrl: change the signature of pinctrl_gpio_direction()
> pinctrl: change the signature of pinctrl_get_device_gpio_range()
> pinctrl: change the signature of pinctrl_match_gpio_range()
> pinctrl: change the signature of gpio_to_pin()
> pinctrl: change the signature of pinctrl_ready_for_gpio_range()

For the above
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

...

> pinctrl: intel: drop the wrappers around pinctrl_gpio_direction_input()

I believe this one can always be done on the driver basis, please split it
to three.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-10-11 19:05    [W:0.388 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site