lkml.org 
[lkml]   [2023]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 20/20] pinctrl: ti: ti-iodelay: Convert to platform remove callback returning void
    On Mon, Oct 9, 2023 at 11:22 AM Uwe Kleine-König
    <u.kleine-koenig@pengutronix.de> wrote:

    > The .remove() callback for a platform driver returns an int which makes
    > many driver authors wrongly assume it's possible to do error handling by
    > returning an error code. However the value returned is ignored (apart
    > from emitting a warning) and this typically results in resource leaks.
    >
    > To improve here there is a quest to make the remove callback return
    > void. In the first step of this quest all drivers are converted to
    > .remove_new(), which already returns void. Eventually after all drivers
    > are converted, .remove_new() will be renamed to .remove().
    >
    > Trivially convert this driver from always returning zero in the remove
    > callback to the void returning variant.
    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    Patch applied.

    Yours,
    Linus Walleij

    \
     
     \ /
      Last update: 2023-10-10 15:47    [W:4.073 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site