lkml.org 
[lkml]   [2023]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] mfd: Use device_get_match_data()
On Tue, Oct 10, 2023 at 3:27 AM Chen-Yu Tsai <wens@csie.org> wrote:
>
> On Tue, Oct 10, 2023 at 5:14 AM Rob Herring <robh@kernel.org> wrote:
> >
> > Use preferred device_get_match_data() instead of of_match_device() to
> > get the driver match data. With this, adjust the includes to explicitly
> > include the correct headers.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > drivers/mfd/axp20x.c | 22 +++-------------------
>
> I'd keep the error message, but otherwise for axp20x,

Why? It can't happen. We already matched successfully in order to
probe, so matching again in probe is redundant and won't fail.

> Reviewed-by: Chen-Yu Tsai <wens@csie.org>

Thanks.

Rob

\
 
 \ /
  Last update: 2023-10-10 13:45    [W:0.080 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site