lkml.org 
[lkml]   [2023]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net 3/4] selftests: openvswitch: Skip drop testing on older kernels
From
Date
On Fri, 2023-10-06 at 11:12 -0400, Aaron Conole wrote:
> Kernels that don't have support for openvswitch drop reasons also
> won't have the drop counter reasons, so we should skip the test
> completely. It previously wasn't possible to build a test case
> for this without polluting the datapath, so we introduce a mechanism
> to clear all the flows from a datapath allowing us to test for
> explicit drop actions, and then clear the flows to build the
> original test case.
>
> Fixes: 4242029164d6 ("selftests: openvswitch: add explicit drop testcase")
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
> .../selftests/net/openvswitch/openvswitch.sh | 17 ++++++++++
> .../selftests/net/openvswitch/ovs-dpctl.py | 34 +++++++++++++++++++
> 2 files changed, 51 insertions(+)
>
> diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh b/tools/testing/selftests/net/openvswitch/openvswitch.sh
> index 2a0112be7ead5..ca7090e71bff2 100755
> --- a/tools/testing/selftests/net/openvswitch/openvswitch.sh
> +++ b/tools/testing/selftests/net/openvswitch/openvswitch.sh
> @@ -144,6 +144,12 @@ ovs_add_flow () {
> return 0
> }
>
> +ovs_del_flows () {
> + info "Deleting all flows from DP: sbx:$1 br:$2"
> + ovs_sbx "$1" python3 $ovs_base/ovs-dpctl.py del-flows "$2"
> + return 0

The chunk above mixes whitespaces and tabs for indenting, please be
consistent.


Thanks!

Paolo

\
 
 \ /
  Last update: 2023-10-10 12:31    [W:0.224 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site