Messages in this thread | | | Date | Tue, 10 Oct 2023 10:02:16 +0100 | From | Jonathan Cameron <> | Subject | Re: [RFC 2/2] iio: imu: Add driver for BMI323 IMU |
| |
On Sun, 8 Oct 2023 11:55:32 +0530 Jagath Jog J <jagathjog1996@gmail.com> wrote:
> Hi Andy, > > > On Wed, Sep 20, 2023 at 4:13 AM Jagath Jog J <jagathjog1996@gmail.com> wrote: > > > > On Mon, Sep 18, 2023 at 3:34 PM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > On Mon, Sep 18, 2023 at 01:33:14PM +0530, Jagath Jog J wrote: > > > > The Bosch BMI323 is a 6-axis low-power IMU that provide measurements for > > > > acceleration, angular rate, and temperature. This sensor includes > > > > motion-triggered interrupt features, such as a step counter, tap detection, > > > > and activity/inactivity interrupt capabilities. > > > > > > ... > > > > > +static const struct attribute_group bmi323_event_attribute_group = { > > > > + .attrs = bmi323_event_attributes, > > > > +}; > > > > > > ATTRIBUTE_GROUPS() ? > > > > Okay, I will use ATTRIBUTE_GROUPS. > > The ATTRIBUTE_GROUP(bmi323_event) macro will define two variables, > bmi323_event_groups and bmi323_event_group. The event_attrs member > of iio_info is of type struct attribute_group*, which means that > bmi323_event_groups will remain unused. Since I am using a single > event group, Can I keep it the same way?
Yes, don't use that macro as not appropriate in this case.
> > > Regards > Jagath > > Jagath
| |