Messages in this thread | | | From | Eric Dumazet <> | Date | Tue, 10 Oct 2023 09:31:10 +0200 | Subject | Re: [PATCH net-next v8] net/core: Introduce netdev_core_stats_inc() |
| |
On Mon, Oct 9, 2023 at 1:16 PM Yajun Deng <yajun.deng@linux.dev> wrote: > > Although there is a kfree_skb_reason() helper function that can be used to > find the reason why this skb is dropped, but most callers didn't increase > one of rx_dropped, tx_dropped, rx_nohandler and rx_otherhost_dropped. > > For the users, people are more concerned about why the dropped in ip > is increasing. > > Introduce netdev_core_stats_inc() for trace the caller of > dev_core_stats_*_inc(). > > Also, add __code to netdev_core_stats_alloc(), as it's called with small > probability. And add noinline make sure netdev_core_stats_inc was never > inlined. > > Signed-off-by: Yajun Deng <yajun.deng@linux.dev> > Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Thanks.
| |